Switch from Ant to Gradle #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #389 +/- ##
==========================================
Coverage 93.65% 93.65%
Complexity 1590 1590
==========================================
Files 102 102
Lines 4743 4744 +1
Branches 828 828
==========================================
+ Hits 4442 4443 +1
Misses 286 286
Partials 15 15 |
Xiangs18
reviewed
Apr 17, 2024
Comment on lines
+19
to
+25
| task buildGitCommitFile { | ||
| doLast { | ||
| def commitId = grgit.head().id | ||
| // is there a variable for builddir/classes/java/main? | ||
| file("$buildDir/classes/java/main/us/kbase/groups/gitcommit").text = commitId | ||
| } | ||
| } |
There was a problem hiding this comment.
What benefits do we get for saving a commit in a file? Verification?
There was a problem hiding this comment.
That commit winds up here: https://ci.kbase.us/services/groups/
so you know what code the server is running
Xiangs18
reviewed
Apr 17, 2024
| @@ -77,10 +70,9 @@ jobs: | |||
| - name: Run tests | |||
| shell: bash | |||
| run: | | |||
| ant ${{matrix.ant_test}} | |||
| gradle ${{matrix.gradle_test}} | |||
There was a problem hiding this comment.
run: ./gradlew test is sufficient? Probably don't need gradle_test: 'test' unless I am missing something important.
There was a problem hiding this comment.
Not for now, but it's a placeholder in case we ever split out the mongo tests as noted in a TODO earlier in the file IIRC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.